Prevent race in TestPersistableChannelQueue #16468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slight race has become apparent in the TestPersistableChannelQueue. This PR simply adds locking to prevent the race. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/testing
skip-changelog
|
attn @6543 |
GiteaBot
added
the
lgtm/need 2
|
-> #1441 |
6543
approved these changes
Jul 17, 2021
GiteaBot
added
lgtm/need 1
KN4CK3R
approved these changes
Jul 17, 2021
GiteaBot
added
lgtm/done
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Prevent race in TestPersistableChannelQueue A slight race has become apparent in the TestPersistableChannelQueue. This PR simply adds locking to prevent the race. * make print value of "$(GOTESTFLAGS)" on test-backend and unit-test-coverage Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slight race has become apparent in the TestPersistableChannelQueue.
This PR simply adds locking to prevent the race.
Related #1441
Signed-off-by: Andrew Thornton [email protected]